-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override panel theme background color with dominant icon color #1564
Open
Austint30
wants to merge
10
commits into
home-sweet-gnome:gnome-40
Choose a base branch
from
Austint30:dominant-color-panel
base: gnome-40
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Override panel theme background color with dominant icon color #1564
Austint30
wants to merge
10
commits into
home-sweet-gnome:gnome-40
from
Austint30:dominant-color-panel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d app icon. Still working on ability to turn this feature on and off.
…urned on and off now.
… formula). Still a bug where brightness value gets set to 0.5 when user sets to 0 in settings.
…se it doesn't care if the app is focused or not.
… well as choose its brightness
…anel. Not seperate like it's supposed to be.
…to default brightness.
That looks really cool! Do you mind if I change the destination branch to master? No worries I'll take care of the conflicts, if any. |
@charlesg99 Yes, go ahead! One thing to note, though. I don't think I properly dealt with translations for the new gsettings options. So if there are translation issues that is why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a feature I've wanted for a while. Using the existing functionality of getting the dominant color from the app icon to highlight the app, I have extended this functionality to the panels.
New features:
I currently haven't upgraded to Gnome 41 yet, so this pull request was built using the gnome-40 version as a base. Feel free to upgrade it to Gnome 41 if you like
2022-01-23.23-36-18_23.53.28.mp4